Improve PageProcessor retained bytes calculations #25602
+220
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
force-pushed
the
add-shallow-size-to-sourcepage
branch
from
42a58be to
9a04414
Compare
wendigo
reviewed
Apr 16, 2025
core/trino-spi/src/main/java/io/trino/spi/connector/SourcePage.java
Outdated
Show resolved
Hide resolved
|
@martint I think we should also land this before the release |
I don't think this is problematic enough to block the release |
|
@raunaqmorarka we've been blocked for 2 weeks on that, 1 or 2 more days doesn't make a difference |
pettyjamesm
force-pushed
the
add-shallow-size-to-sourcepage
branch
2 times, most recently
from
976ce28 to
92d8e30
Compare
dain
reviewed
Apr 18, 2025
pettyjamesm
force-pushed
the
add-shallow-size-to-sourcepage
branch
from
92d8e30 to
94616f2
Compare
pettyjamesm
changed the title
pettyjamesm
force-pushed
the
add-shallow-size-to-sourcepage
branch
from
94616f2 to
c0e0648
Compare
Yeah, that approach reduces the surface area of the |
pettyjamesm
changed the title
pettyjamesm
force-pushed
the
add-shallow-size-to-sourcepage
branch
3 times, most recently
from
c200d06 to
094fe0b
Compare
Ensures that all components of SourcePage implementations are accounted for in their retained bytes and retained bytes for each parts calculations to avoid under-counting the amount of memory being retained. Also ensures that PageProcessor selected positions and previouslyComputedResults array is included in the retained size.
pettyjamesm
force-pushed
the
add-shallow-size-to-sourcepage
branch
from
094fe0b to
afabcad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows up from #25600 by account for all necessary components of
SourcePageimplementations inSourcePage#getRetainedBytes()andSourcePage#retainedBytesForEachPartmethods. Also includesSelectedPositionsandBlock[] previouslyComputedResultsin thePageProcessor.ProjectSelectedPositionsretained size calculation.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: