Add ILIKE operator for case-insensitive pattern matching #27364
+242
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement ILIKE operator following PostgreSQL semantics for case-insensitive string pattern matching. ILIKE works like LIKE but ignores case differences in both the value and pattern. Changes: - Added ILIKE token and grammar rule to SqlBase.g4 - Extended LikePredicate AST node with caseInsensitive flag - Implemented ilikeChar() and ilikeVarchar() functions in LikeFunctions - Added pattern compilation with case-insensitive support in LikePattern - Updated expression analyzer and formatter to handle ILIKE - Added PostgreSQL connector pushdown support for ILIKE - Added comprehensive test coverage in TestLikeFunctions The implementation converts both pattern and values to lowercase using Locale.ROOT for consistent case-insensitive matching across locales. Full support for ESCAPE clause is included. Fixes trinodb#2491
Member
Member
|
Since this can be easily implemented as a function, that’s the preferred approach instead of adding dedicated syntax that’s not covered by the SQL specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the ILIKE operator for case-insensitive pattern matching, addressing #2491. ILIKE follows PostgreSQL semantics and works like LIKE but ignores case differences in both the value and pattern.
The implementation provides a native way to perform case-insensitive pattern matching without requiring manual
lower()calls on both sides of the comparison.Additional context and related issues
Rather than creating a separate ILIKE AST node, the implementation extends the existing
LikePredicatewith acaseInsensitiveboolean flag. This minimizes code duplication and leverages the existing pattern matching infrastructure.Compatibility:
ILIKE is natively supported by PostgreSQL, Snowflake, DuckDB, Databricks, and Redshift. This implementation works with all Trino connectors - pushdown is enabled for PostgreSQL, while other connectors evaluate ILIKE in Trino's engine.
Release notes
(x) Release notes are required, with the following suggested text: