Do not buffer response during async execution #27373
Open
+99
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/do-not-buffer
branch
from
bb8dd7d to
f8cf9c3
Compare
|
Started benchmark workflow for this PR with test type =
|
|
Started benchmark workflow for this PR with test type =
|
wendigo
force-pushed
the
serafin/do-not-buffer
branch
2 times, most recently
from
c3d8bdb to
3208109
Compare
HttpClient's executeAsync always buffers the entire response before handing it over to the ResponseHandler. This is inefficent as the decoding could be streaming and that doesn't require large amount of memory while reading results.
This helps to detect regressions around handling of large requests by HttpPageBufferClient E.g. failures like Buffering capacity 67108864 exceeded after a Jetty update (cherry picked from commit f4d0198)
wendigo
force-pushed
the
serafin/do-not-buffer
branch
from
3208109 to
dce8aaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClient's executeAsync always buffers the entire response before handing it over to the ResponseHandler. This is inefficent as the decoding could be streaming and that doesn't require large amount of memory while reading results.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: