Parquet reader - avoid redundant dictionary reads #27407
+438
−263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid redundant dictionary reads - earlier the dictionary page is read at the time of rowgroup pruning (
PredicateUtils) and then again read during the actual file reading(ParquetReader). This PR removes this redundant work and moves dictionary based rowgroup pruning logic toParquetReaderWould like to thank @pettyjamesm for his initial suggestions on this.
Some numbers with patch
These queries were run on 1TB TPC-DS data(parquet, zstd compressed).
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: