Add active worker count and active coordinator count metrics #27408
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertjanal
force-pushed
the
add_activeWorkerCount_and_activeCoordinatorCount_metrics
branch
from
c3f98f0 to
8243d5f
Compare
gertjanal
force-pushed
the
add_activeWorkerCount_and_activeCoordinatorCount_metrics
branch
2 times, most recently
from
9990048 to
55146ba
Compare
gertjanal
commented
Nov 23, 2025
| private final boolean worker; | ||
| private final long longHashCode; | ||
|
|
||
| public InternalNode(String nodeIdentifier, URI internalUri, NodeVersion nodeVersion, boolean coordinator) |
Contributor
Author
There was a problem hiding this comment.
This constructor is used in quite some test files. Shall I remove this constructor and update the tests, or shall I keep it this way?
gertjanal
force-pushed
the
add_activeWorkerCount_and_activeCoordinatorCount_metrics
branch
from
55146ba to
110890f
Compare
| <item> | ||
| <ignore>true</ignore> | ||
| <code>java.method.addedToInterface</code> | ||
| <new>method boolean io.trino.spi.Node::isWorker()</new> |
Contributor
There was a problem hiding this comment.
It's unnecessary to add it, since the worker means not coordinator. we already has isCoordinator, why not just reuse it
Contributor
Author
There was a problem hiding this comment.
Because a node can be a worker and coordinator at the same time using node-scheduler.include-coordinator as described here: https://trino.io/docs/current/installation/deployment.html#config-properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
/metricsendpoint lists active nodes, but not all nodes are workers and # of workers is not always equal to # nodes - # coordinators as coordinators can be workers as well.This PR adds
CoordinatorNodeManager_ActiveCoordinatorCountandCoordinatorNodeManager_ActiveWorkerCountmetrics. I can't find any tests for the current metrics in theCoordinatorNodeManager, so I'm not sure they should be added.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( X ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: