Tests: Remove AWS region derivation in REST container and clean up catalog properties #27417
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| "s3.session-token", minioSessionToken, | ||
| "s3.endpoint", "http://minio:4566", | ||
| "s3.path-style-access", "true", | ||
| "client.region", MINIO_REGION)), |
There was a problem hiding this comment.
I think we can do this, using an explicit Iceberg property, instead of setting AWS_REGION as an env var for the AWS SDK to derive region from
smaheshwar-pltr
force-pushed
the
sm/rest-container
branch
from
7669bcf to
2f5f843
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| return getMappedHostAndPortForExposedPort(8181).toString(); | ||
| } | ||
|
|
||
| private static Map<String, String> toCatalogEnvVars(Map<String, String> properties) |
There was a problem hiding this comment.
Reverses https://github.com/databricks/iceberg-rest-image/blob/62a5078032e0675d34b377d2ead2eea814c1da48/src/main/java/org/apache/iceberg/rest/RESTCatalogServer.java#L46-L62, so the constructor is more readable as it just uses standard Iceberg properties
1 participant
Description
IcebergRestCatalogBackendContainerrelies on the container deriving the AWS region from an environment variable, but this can be set instead with an Iceberg property,client.regionAdditional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: