Skip to content

Conversation

Copy link

Copilot AI commented Nov 26, 2025

Fix Hudi 1.1.0 Dependency Update Test Failures

Problem

PR #27365 updates Hudi from 1.0.2 to 1.1.0, but tests fail with empty result sets.

Root Cause

Original PR used startCommit() but Hudi 1.1.0 requires createNewInstantTime() + startCommitWithTime().

Fix

  • Updated TpchHudiTablesInitializer.java to use proper Hudi 1.1.0 API pattern
  • Verify fix on CI

Changed from:

String newCommitTime = writeClient.startCommit();

To:

String newCommitTime = writeClient.createNewInstantTime();
writeClient.startCommitWithTime(newCommitTime);
Original prompt

#27365 includes dependency update, but doesn't pass the tests. Can you help?


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@cla-bot
Copy link

cla-bot bot commented Nov 26, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@findepi
Copy link
Member

findepi commented Nov 26, 2025

Changes were pushed to Copilot's branch while it was working, and Copilot was unable to merge its changes with the contents of the remote branch. See logs for details. If the problem persists, please contact GitHub Support. To retry, leave a comment on this pull request asking Copilot to try again.

That's not cool. No-one was pushing anything except @copilot .

@findepi findepi closed this Nov 26, 2025
@findepi findepi deleted the copilot/fix-dependency-update-tests branch November 26, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants