Fix failure reading `FLOAT` type in `Query` table function in Oracle #27880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ebyhr merged 1 commit into trinodb:master from chenjian2664:jack/fix-float-type-ptf-oracle

Jan 20, 2026

+100 −0

Contributor

chenjian2664 commented Jan 8, 2026 •

edited by ebyhr

Loading

Description

Reading FLOAT in Query table function in Oracle will fail with:

io.trino.testing.QueryFailedException: com.google.common.util.concurrent.UncheckedExecutionException: 
java.lang.UnsupportedOperationException: 
Unsupported type: JdbcTypeHandle[jdbcType=2, jdbcTypeName=Optional[NUMBER], columnSize=Optional[126], decimalDigits=Optional[-127], arrayDimensions=Optional.empty, caseSensitivity=Optional[CASE_INSENSITIVE]] of column: Y

The return types in Query table function are derived from a prepared query https://github.com/trinodb/trino/blob/ce0492437e72d9e7483ef0028a941b333f82e488/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/ptf/Query.java#L99C8-L106
Oracle will declare type to NUMBER for the FLOAT type.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Oracle
* Fix failure when reading `float` type in `query` table function. ({issue}`27880`)

cla-bot bot added the cla-signed label

github-actions bot added the oracle label

chenjian2664 force-pushed the jack/fix-float-type-ptf-oracle branch from 5ff6b71 to 19052a6 Compare

January 8, 2026 03:20

chenjian2664 requested review from ebyhr and findepi

January 8, 2026 03:21

findepi reviewed

View reviewed changes

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Show resolved Hide resolved

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Outdated Show resolved Hide resolved

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Outdated Show resolved Hide resolved

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Outdated Show resolved Hide resolved

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Outdated

    
                              Optional.of(caseSensitive));

                  }

                  private static boolean isAllowedNumber(int precision, int columnSize)

Member

findepi Jan 9, 2026

Why this doesn't compare columnSize and precision values?

Contributor Author

chenjian2664 Jan 12, 2026

Updated the logic to follow

trino/plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java

Lines 507 to 520 in 2d36105

    
           if (precision < scale) { 
        
               if (roundingMode == RoundingMode.UNNECESSARY) { 
        
                   break; 
        
               } 
        
               scale = min(Decimals.MAX_PRECISION, scale); 
        
               precision = scale; 
        
           } 
        
           else if (numberDefaultScale.isPresent() && precision == PRECISION_OF_UNSPECIFIED_NUMBER) { 
        
               precision = Decimals.MAX_PRECISION; 
        
               scale = numberDefaultScale.get(); 
        
           } 
        
           else if (precision > Decimals.MAX_PRECISION || actualPrecision <= 0) { 
        
               break; 
        
           }

The purpose of the method is to check if it is able to be handled as the NUMBER - as we could always correct interpret the type and with less "lossy"
If it not, we use it actual type - FLOAT

findinpath requested a review from krvikash

January 9, 2026 08:51

chenjian2664 requested a review from findepi

January 12, 2026 01:15

krvikash reviewed

View reviewed changes

plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/BaseOracleConnectorTest.java Outdated Show resolved Hide resolved

chenjian2664 requested a review from krvikash

January 12, 2026 08:03

krvikash reviewed

View reviewed changes

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Show resolved Hide resolved

krvikash approved these changes

View reviewed changes

plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/BaseOracleConnectorTest.java Outdated Show resolved Hide resolved

chenjian2664 force-pushed the jack/fix-float-type-ptf-oracle branch from 80c4b57 to 974aefb Compare

January 14, 2026 11:22

krvikash approved these changes

View reviewed changes

ebyhr approved these changes

View reviewed changes

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Outdated Show resolved Hide resolved

plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/BaseOracleConnectorTest.java Outdated Show resolved Hide resolved

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Show resolved Hide resolved

Praveen2112 reviewed

View reviewed changes

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java

    
                      return columns.build();

                  }

                  private static JdbcTypeHandle getJdbcTypeHandle(ConnectorSession session, ResultSetMetaData metadata, int column)

Member

Praveen2112 Jan 15, 2026

nit: columnIndex

Contributor Author

chenjian2664 Jan 16, 2026

I want to make consistency with

trino/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java

Line 295 in 195d536

for (int column = 1; column <= metadata.getColumnCount(); column++) {

so, let's keep the column as the name

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java

    
                  {

                      ImmutableList.Builder<JdbcColumnHandle> columns = ImmutableList.builder();

                      for (int column = 1; column <= metadata.getColumnCount(); column++) {

                          JdbcTypeHandle jdbcTypeHandle = getJdbcTypeHandle(session, metadata, column);

Member

Praveen2112 Jan 15, 2026

Should we introduce getJdbcTypeHandle as an extension point so that connectors could implement their logic without mimicing the boilder plate code ?

Contributor Author

chenjian2664 Jan 16, 2026

Currently only Oracle has the requirements, so seems not so urgent to do such extension, wdyt?

plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java Show resolved Hide resolved

chenjian2664 requested a review from Praveen2112

January 16, 2026 03:24

Praveen2112 approved these changes

View reviewed changes


          Fix failure reading FLOAT type in Query table function in Oracle

28178dc

ebyhr force-pushed the jack/fix-float-type-ptf-oracle branch from ca69056 to 28178dc Compare

January 20, 2026 01:22

ebyhr merged commit f84c750 into trinodb:master

7 of 15 checks passed

github-actions bot added this to the 480 milestone

chenjian2664 deleted the jack/fix-float-type-ptf-oracle branch

January 20, 2026 04:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed oracle