Document VM required option for *QueryRunner classes in README #27940
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelsolarski
force-pushed
the
readme-update-for-running-query-runner
branch
from
cdc558d to
82d5d6e
Compare
ebyhr
approved these changes
Jan 16, 2026
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Readme fixup for running *QueryRunner classes
Could you change the commit title to "Document VM option for query runners in README" or something similar?
https://trino.io/development/process.html#pull-request-and-commit-guidelines is the commit message guideline in this project:
- Use the imperative mood, as used in a command or request, in the subject line.
chenjian2664
approved these changes
Jan 16, 2026
raphaelsolarski
force-pushed
the
readme-update-for-running-query-runner
branch
from
82d5d6e to
30dc668
Compare
raphaelsolarski
changed the title
findepi
reviewed
Jan 16, 2026
README.md
Outdated
| server. Many other connectors have their own `*QueryRunner` class that you can | ||
| use when working on a specific connector. | ||
| use when working on a specific connector. The only generally required VM option | ||
| here is `--add-modules jdk.incubator.vector` but various. |
Member
There was a problem hiding this comment.
"but various" -- looks truncated
Member
Author
There was a problem hiding this comment.
sorry, "dynamic programming". Fixed
raphaelsolarski
force-pushed
the
readme-update-for-running-query-runner
branch
from
30dc668 to
1f0a7f5
Compare
raphaelsolarski
force-pushed
the
readme-update-for-running-query-runner
branch
from
1f0a7f5 to
1cbbdc5
Compare
findepi
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just little readme fixup to save another person's time.