Replace return with continue in SET DATA TYPE tests
#27958
Merged
+58
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The ci looks related |
ebyhr
force-pushed
the
ebi/iceberg-set-row-type
branch
from
08922e0 to
b2a3f4e
Compare
ebyhr
force-pushed
the
ebi/iceberg-set-row-type
branch
from
b2a3f4e to
e4e5088
Compare
Also, update the relevant test cases.
ebyhr
force-pushed
the
ebi/iceberg-set-row-type
branch
from
e4e5088 to
ae3e96c
Compare
chenjian2664
approved these changes
Jan 20, 2026
wendigo
approved these changes
Jan 20, 2026
findepi
reviewed
Jan 20, 2026
| if (setup.unsupportedType) { | ||
| assertThatThrownBy(setColumnType::run) | ||
| .satisfies(this::verifySetColumnTypeFailurePermissible); | ||
| return; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Otherwise, the test may exit unexpectedly without running all cases.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.