Codestyle improvements driven by error-prone suggestions#28311
Open
findepi wants to merge 4 commits intotrinodb:masterfrom
Open
Codestyle improvements driven by error-prone suggestions#28311findepi wants to merge 4 commits intotrinodb:masterfrom
findepi wants to merge 4 commits intotrinodb:masterfrom
Conversation
Use Optional for checking that lambda has been set
Improve readability. This was driven by UnnecessaryLambda error-prone check, but the check is not enabled in this commit and only some matching places are updated.
findepi
added
the
no-release-notes
github-actions
bot
added
iceberg
It encourages that the format and substitutions are close to each other, which makes sense given substitutions are replaced positionally.
losipiuk
approved these changes
Feb 16, 2026
wendigo
approved these changes
Feb 16, 2026
martint
requested changes
Feb 16, 2026
Member
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Enable InlineFormatString error-prone check
It encourages that the format and substitutions are close to each other,
which makes sense given substitutions are replaced positionally.
Encouraging where it makes sense and where it improves readability is ok. Forcing in in every scenario is not, as it sometimes sacrifices readability due to too many levels of nesting and too much code in a single callsite.
Member
Author
|
There is always escape hatch via suppress warning annotation. Are you concerned about particular changes made in this PR? Or the changes in PR are good, but you're concerned with the check existence? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.