Add ConnectorIdentifier to Connector#28359
Open
prrvchr wants to merge 1 commit intotrinodb:masterfrom
Open
Conversation
github-actions
bot
added
druid
prrvchr
force-pushed
the
fix#28356
branch
3 times, most recently
from
e363612 to
291d021
Compare
github-actions
bot
added
iceberg
Member
Author
|
@wendigo Here's how it's possible to switch to mixed case with Trino while maintaining a minimum of backward compatibility. This requires more changes than expected and is only implemented for views. |
martint
requested changes
Feb 19, 2026
Comment on lines
+24
to
+27
| public class ConnectorIdentifier | ||
| { | ||
| private final String value; | ||
| private final boolean delimited; |
Member
There was a problem hiding this comment.
Names coming from connectors don't have a delimited / non-delimited characteristic. They are already canonicalized. The delimited characteristic only pertains to identifiers parsed from a SQL query, and matters only for deciding how to match identifiers to names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am trying to add a functional comparator for identifiers that support delimiters.
The new class
ConnectorIdentifieris intended to do so. It also allows the connector to know whether the DDL commands for which it is responsible should be executed with delimited identifiers or not.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: