Add fields for $files table delete file deduplication#28933
Open
kaveti wants to merge 2 commits intotrinodb:masterfrom
Open
Add fields for $files table delete file deduplication#28933kaveti wants to merge 2 commits intotrinodb:masterfrom
kaveti wants to merge 2 commits intotrinodb:masterfrom
Conversation
kaveti
force-pushed
the
files-table-dedup
branch
2 times, most recently
from
3174be5 to
2399782
Compare
| pageBuilder.declarePosition(); | ||
| long start = System.nanoTime(); | ||
| ContentFile<?> contentFile = contentIterator.next(); | ||
| long start = System.nanoTime(); |
Contributor
There was a problem hiding this comment.
Revert the unrelated change
| } | ||
|
|
||
| @Test | ||
| public void testFilesTableDeleteFileDeduplication() |
Contributor
There was a problem hiding this comment.
Could you add the test in v3?
I initially thought the request was to include offset and length to describe the delete file, so it would be good to have a test that demonstrates we currently don't support this
cc @findinpath
kaveti
force-pushed
the
files-table-dedup
branch
3 times, most recently
from
fa89958 to
a2e9b9e
Compare
ebyhr
reviewed
Apr 7, 2026
| public static final String EQUALITY_IDS_COLUMN_NAME = "equality_ids"; | ||
| public static final String SORT_ORDER_ID_COLUMN_NAME = "sort_order_id"; | ||
| public static final String CONTENT_OFFSET_COLUMN_NAME = "content_offset"; | ||
| public static final String CONTENT_SIZE_IN_BYTES_COLUMN_NAME = "content_size_in_bytes"; |
Member
There was a problem hiding this comment.
Please update $files section in iceberg.md.
ebyhr
reviewed
Apr 7, 2026
| .map(row -> (String) row.getField(0))) | ||
| .doesNotContain("content_offset", "content_size_in_bytes"); | ||
| // Each DV entry has distinct content_offset within the shared Puffin file | ||
| assertQuery( |
Member
There was a problem hiding this comment.
assertQuery isn't recommend. Use assertThat(query(...)) instead.
Add testFilesTableDeleteFileDeduplication to BaseIcebergSystemTables that verifies the $files table shows each delete file exactly once, with no duplicate entries (v2 position + equality deletes). Add testFilesTableDeletionVectors that verifies v3 deletion vector behavior: multiple DV entries share the same Puffin file_path in the $files table. Currently there are no content_offset/content_size_in_bytes columns to distinguish individual DVs within the shared Puffin file. Follow-up to trinodb#28911 as requested by findinpath.
kaveti
force-pushed
the
files-table-dedup
branch
from
a2e9b9e to
499496c
Compare
kaveti
changed the title
Contributor
|
Could we move forward with: #29044 ? It adds the same fields + some more, how do folks feel about it? |
Contributor
Author
|
@oskar-szwajkowski we can break it two PRs or have it in one & close this one . i'm good with anything |
Contributor
|
lets see how @chenjian2664 sees it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add testFilesTableDeleteFileDeduplication to BaseIcebergSystemTables that verifies the $files table shows each delete file exactly once, with no duplicate entries from FileScanTask expansion.
Follow-up to #28911 as requested by findinpath.
New Fields
content_offsetBIGINTvectors stored in shared Puffin files.
content_size_in_bytesBIGINTvectors stored in shared Puffin files.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: