Improve documentation wording and fix typos#29002
Open
electrum wants to merge 1 commit intotrinodb:masterfrom
Open
Improve documentation wording and fix typos#29002electrum wants to merge 1 commit intotrinodb:masterfrom
electrum wants to merge 1 commit intotrinodb:masterfrom
Conversation
mosabua
approved these changes
Apr 7, 2026
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Nice collection of small improvements..
|
|
||
| ``` | ||
| vale src/main/sphinx/overview/use-cases.md | ||
| vale docs/src/main/sphinx/overview/use-cases.md |
Member
There was a problem hiding this comment.
It was not using the docs folder since the readme is already in that folder but I guess this works too
| for x86 architectures, so if you're building on Apple Silicon, you need | ||
| to have Rosetta 2 installed | ||
| for x86 architectures, so if you're building on Apple Silicon, you need | ||
| to have Rosetta 2 installed. |
Member
There was a problem hiding this comment.
Arguably this sucks and ideally we get rid of this restriction .. not even sure which packages they are actually .. do you know if this is still true @koszti ?
chenjian2664
approved these changes
Apr 9, 2026
| and optionally use the [trino-packages project](https://github.com/trinodb/trino-packages) | ||
| or manually [download the plugin archive](https://central.sonatype.com/artifact/io.trino/trino-http-server-event-listener) | ||
| for your installation and version. No newline at end of file | ||
| for your installation and version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.