Operator tests code improvement#29803
Merged
Merged
Conversation
Some tests do not pass without `-XX:-OmitStackTraceInFastThrow`. For example `TestTimestamp.testDateAdd` is flaky when the whole class is run without that flag.
A safer alternative to `.build().get(0)` which could discard data if there is more than one page.
`getOnlyElement` is more fool-proof.
While `List<? extends Type>` is "more correct", `List<Type>` is easier to read and more consistent with other code places.
findepi
added
test
no-release-notes
findepi
force-pushed
the
findepi/tests
branch
2 times, most recently
from
842c3f3 to
a60bacb
Compare
wendigo
approved these changes
Jun 11, 2026
It was unused by the class, served as a pass-through value.
Removes the need to merge pages for the sake of assertion.
Silences IDE warning about unclosed operator instances.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review individual commits