Add Floci GCS filesystem tests#29970
Merged
electrum merged 1 commit intoJun 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Floci (floci-gcp) container-backed tests for the GCS filesystem implementation, including exercising pre-signed URIs and server-side encryption with customer-provided keys, and updates the GCS filesystem to generate pre-signed URLs that respect a configured custom endpoint (needed for emulators).
Changes:
- Introduce a
FlociGcpTestcontainers wrapper and newTestGcsFileSystemFloci*test suites (plain + encryption). - Add
TestingSigningCredentialsfor signing pre-signed URLs in tests without relying on real GCP credentials. - Plumb
gcs.endpointintoGcsFileSystemand use it when generating V4 signed URLs; refactor GCS test initialization to accept custom config/auth; add needed test dependencies.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testing/trino-testing-containers/src/main/java/io/trino/testing/containers/FlociGcp.java | Adds a Testcontainers wrapper for the floci-gcp emulator. |
| lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestingSigningCredentials.java | Adds test-only credentials implementing ServiceAccountSigner for signed URL generation. |
| lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemFlociWithEncryption.java | Adds encryption variant of the Floci-backed GCS filesystem test suite. |
| lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemFloci.java | Adds Floci-backed GCS filesystem tests using a container endpoint and signing creds. |
| lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/AbstractTestGcsFileSystem.java | Refactors initialization to allow passing a custom config and auth implementation. |
| lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemFactory.java | Passes configured endpoint into GcsFileSystem instances. |
| lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystem.java | Uses configured endpoint hostname when generating pre-signed URLs. |
| lib/trino-filesystem-gcs/pom.xml | Adds Testcontainers JUnit Jupiter and testing-containers module as test dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dain
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Floci-backed GCS filesystem tests, including coverage for encrypted operations and pre-signed URIs.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.