Converts the build to Gradle Kotlin DSL#14155
Converts the build to Gradle Kotlin DSL#14155tresat wants to merge 2 commits intotriplea-game:mainfrom
Conversation
tresat
force-pushed
the
tt/build/convert-build-to-kotlin-dsl
branch
from
d4b5521 to
3c016ed
Compare
frigoref
left a comment
frigoref
left a comment
There was a problem hiding this comment.
Just some one typo and an idea to improve transparency about TripleA configurations by introducting constants.
| Gradle plugins used by the build are located in `/gradle/build-logic`. | ||
|
|
||
| The build uses the Gradle Kotlin DSL. | ||
| This make the build easier to maintain by increasing the completion and refactoring assistance the IDE is able to provide. |
| maven(MavenPublication) { | ||
| artifact(tasks.named(sourceSets.main.jarTaskName)) { | ||
| extension 'jar' | ||
| create<MavenPublication>("maven") { |
There was a problem hiding this comment.
Can we work with constants here for which their names can help to understand better what this is?
| extension 'jar' | ||
| create<MavenPublication>("maven") { | ||
| artifact(tasks.named(sourceSets.main.get().jarTaskName)) { | ||
| extension = "jar" |
There was a problem hiding this comment.
Didn't we have a constant for that already?
There was a problem hiding this comment.
This file is just a copy of the previous build.gradle, right?
Should we try to declare constants there as well with another commit or another PR?
I'd suggest to have at least constants for what is "TripleA configuration" like paths even though we keep strings for what is "Kotlin configuration" like plugins. What do you think?
There was a problem hiding this comment.
Also here, maybe some constants would help.
There was a problem hiding this comment.
Also here, maybe some constants would help.
There was a problem hiding this comment.
Also here, maybe some constants would help.
There was a problem hiding this comment.
Also here, maybe some constants would help.
There was a problem hiding this comment.
Also here, maybe some constants would help.
There was a problem hiding this comment.
Also here, maybe some constants would help.
2 participants
There should be zero behavior changes from this.