docs: update for roslyn.nvim changes #75
Conversation
WalkthroughThe README documentation was updated to simplify the Roslyn LSP command setup instructions. Conditional logic for command construction was removed, and the example configuration now uses a fixed command list and updated setup method. An explicit enablement step for the Roslyn LSP client was also added to the usage example. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Neovim
participant Roslyn LSP
User->>Neovim: Configure Roslyn LSP using fixed command
User->>Neovim: Call vim.lsp.enable("roslyn")
Neovim->>Roslyn LSP: Start Roslyn LSP server with predefined arguments
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
121-132: Clarifyroslynbinary resolution
The snippet now invokes"roslyn"directly. Users must have theroslynCLI on theirPATH(e.g., via Mason’s registry). Consider adding a note or example showing how to retrieve its absolute path from the Mason registry, for example:local mr = require("mason-registry") local roslyn_pkg = mr.get_package("roslyn") local roslyn_cmd = vim.fn.joinpath(roslyn_pkg:get_install_path(), "bin", "roslyn")This will help avoid “command not found” errors.
165-189: Verify and document new LSP setup API
The example replacesrequire("roslyn").setupwith:vim.lsp.config("roslyn", { … }) vim.lsp.enable("roslyn")Please confirm that:
- The target
roslyn.nvimrelease supportsvim.lsp.configandvim.lsp.enable/disable.- Users know the minimum Neovim version required for
vim.lsp.enable.- The
handlerstable is correctly passed at the top level, not nested underconfig.If all checks out, add a brief note explaining this migration so users upgrading from older configs aren’t caught off guard.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
README.md(3 hunks)
|
Note to self, you cant override the capabilities, as this leads to no diags |
Our side of seblyng/roslyn.nvim#178
Summary by CodeRabbit