[18.0][MIG] sell_only_by_packaging: Migration to 18.0#10
Closed
[18.0][MIG] sell_only_by_packaging: Migration to 18.0#10
Conversation
trisdoan
force-pushed
the
18.0-mig-sell_only_by_packaging
branch
4 times, most recently
from
b651d4a to
aa3479a
Compare
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sell_only_by_packaging Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sell_only_by_packaging/
Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sell_only_by_packaging Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sell_only_by_packaging/es/
This test was relying on the fact that it was being tested along with `sale_packaging_default`. But there's no direct dependency between these modules. Besides, that assertion was never executed, so I removed it. @moduon MT-3930
Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sell_only_by_packaging Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sell_only_by_packaging/it/
xaviedoanhduy
suggested changes
Dec 6, 2024
| templates._check_sell_only_by_packaging_can_be_sold_packaging_ids() | ||
| except exceptions.ValidationError as e: | ||
| raise exceptions.ValidationError( | ||
| _( |
There was a problem hiding this comment.
Suggested change
| _( | |
| self.env._( |
You can replace the call to translate a string (
_) withself.env._for getting some performance improvement in some cases. See odoo/odoo#174844.
| 'Packaging level "{}" must stay with "Can be sold",' | ||
| ' at least one product configured as "sell only' | ||
| ' by packaging" is using it.' | ||
| ).format(record.display_name) |
There was a problem hiding this comment.
please also get rid of the .format, see https://github.com/OCA/odoo-module-migrator/pull/114
(here and in other locations; also impact translations)
| def _compute_template_min_sellable_qty(self): | ||
| for record in self: | ||
| record.min_sellable_qty = 0.0 | ||
| if len(record.product_variant_ids) == 1: |
There was a problem hiding this comment.
Suggested change
| if len(record.product_variant_ids) == 1: | |
| if record.product_variant_count == 1: |
Owner
Author
There was a problem hiding this comment.
What would we gain from triggering a compute method?
| for product in self: | ||
| if product.sell_only_by_packaging and not product.sale_ok: | ||
| raise ValidationError( | ||
| _( |
There was a problem hiding this comment.
Suggested change
| _( | |
| self.env._( |
same with all _( above code
Comment on lines
+57
to
+60
| len(product.product_variant_ids) == 1 | ||
| and not any(pack.sales for pack in product.packaging_ids) | ||
| # Product variants condition | ||
| or len(product.product_variant_ids) > 1 |
There was a problem hiding this comment.
Suggested change
| len(product.product_variant_ids) == 1 | |
| and not any(pack.sales for pack in product.packaging_ids) | |
| # Product variants condition | |
| or len(product.product_variant_ids) > 1 | |
| product.product_variant_count == 1 | |
| and not any(pack.sales for pack in product.packaging_ids) | |
| # Product variants condition | |
| or product.product_variant_count > 1 |
There was a problem hiding this comment.
The code here seems to be mostly duplicated with the product_packaging_level_salable module, right?
https://github.com/trisdoan/product-attribute/blob/18.0-mig-product_packaging_level_salable/product_packaging_level_salable/tests/common.py
trisdoan
force-pushed
the
18.0-mig-sell_only_by_packaging
branch
2 times, most recently
from
8c8e6b3 to
b52008d
Compare
trisdoan
force-pushed
the
18.0-mig-sell_only_by_packaging
branch
from
b52008d to
3ccc34a
Compare
xaviedoanhduy
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note