refactor: Drop once_cell in favor of OnceLock/LazyLock#576
Open
CosmicHorrorDev wants to merge 1 commit intotrishume:masterfrom
Open
refactor: Drop once_cell in favor of OnceLock/LazyLock#576CosmicHorrorDev wants to merge 1 commit intotrishume:masterfrom
CosmicHorrorDev wants to merge 1 commit intotrishume:masterfrom
Conversation
CosmicHorrorDev
commented
Mar 15, 2025
| /// | ||
| /// Only [`Scope`]s created by the same repository have valid comparison results. | ||
| /// | ||
| /// [`SCOPE_REPO`]: struct.SCOPE_REPO.html |
Contributor
Author
There was a problem hiding this comment.
The function should get auto-linked, so I dropped this explicit link, but lmk if that's wrong for some reason
CosmicHorrorDev
commented
Mar 15, 2025
| impl core::panic::unwind_safe::UnwindSafe for syntect::parsing::SyntaxSetBuilder | ||
| pub const syntect::parsing::ATOM_LEN_BITS: u16 = 3u16 | ||
| pub static syntect::parsing::SCOPE_REPO: once_cell::sync::Lazy<std::sync::mutex::Mutex<syntect::parsing::ScopeRepository>> | ||
| pub fn syntect::parsing::scope_repo() -> &'static std::sync::mutex::Mutex<syntect::parsing::ScopeRepository> |
Contributor
Author
There was a problem hiding this comment.
Already mentioned in #575, but this is a breaking change 💥
Collaborator
There was a problem hiding this comment.
If we need to break semver anyway, it is probably better to completely remove it from the public API? We can always add it back in a minor release if someone depends on it.
CosmicHorrorDev
force-pushed
the
once-upon-a-lock
branch
from
db6e79c to
0e59976
Compare
CosmicHorrorDev
force-pushed
the
once-upon-a-lock
branch
from
0e59976 to
008a9b8
Compare
keith-hall
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #575
I stuck with
OnceLockfor the library itself to keep the MSRV bump to just 1.70 instead of 1.80. This did involve refactoringSCOPE_REPOto a function that internally handles initialization to approximate whatLazydoes