Adding sortCanceled. Passing header in Event details.
#227
+14
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent project I need to show or hide certain table content based on which column the user wants to sort-by. Currently I'm only able to do this in the
afterSortevent by inspecting the<thead>fortr > *[aria-sort]- but this isn't ideal.Ideally I'd like to filter/edit data in the
beforeSortevent, however this isn't possible because thebeforeSortevent is raised before thearia-sort=""attributes are updated and no useful data (other than thethisreference to theHTMLTableElement) is included in theEventobject....so this PR uses
CustomEvent'sdetailproperty to allow the listener ofafterSortandbeforeSortto get theheader(<th>) andupdatevalues.I've also added a new event:
sortCanceled, as thetableSortfunction will simply return (without providing any indication to the consuming page/application's script that it was aborted) after callingbeforeSortif there's no data to sort, which I think violates expectations about the pairing of events.