Fix data-sort-reverse attribute #248
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the pull request tristen#184. The current implementation of data-sort-reverse does not respect the aria-sort value. For example, when aria-sort is ascending, it is actually sorting in descending order.
|
I realized I did not build the minified files. Let me know if you want them @tristen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the implementation of
data-sort-reverseattribute that was proposed in the pull request #184.The current implementation of
data-sort-reversedoes not respect thearia-sortvalue. For example, whenaria-sortis ascending, it is actually sorting in descending order.