Add TRITONSERVER_ServerOptionsSetLogCallback API#463
Open
nbarbier-amira wants to merge 1 commit intotriton-inference-server:mainfrom
Open
Add TRITONSERVER_ServerOptionsSetLogCallback API#463nbarbier-amira wants to merge 1 commit intotriton-inference-server:mainfrom
nbarbier-amira wants to merge 1 commit intotriton-inference-server:mainfrom
Conversation
This adds a C API function to register a callback for receiving log
messages, enabling applications to integrate Triton logging with
external logging systems.
New API:
- TRITONSERVER_LogCallbackFn_t: Callback function type definition
- TRITONSERVER_ServerOptionsSetLogCallback(): Register/unregister callback
The callback receives:
- TRITONSERVER_LogLevel: The log level (INFO, WARN, ERROR)
- filename: Source file where the log originated
- line: Line number in the source file
- msg: The formatted log message
- userp: User-provided context pointer
The 'replace_default_logger' parameter controls whether the callback
replaces the default logging behavior or is called in addition to it.
Example usage (C):
void my_log_callback(
TRITONSERVER_LogLevel level, const char* filename, int line,
const char* msg, void* userp) {
// Forward to application logging system
}
TRITONSERVER_ServerOptionsSetLogCallback(
options, my_log_callback, my_context, true);
Requires corresponding changes in triton-inference-server/common.
Resolves triton-inference-server/server#8304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a C API for registering a log callback, allowing applications using the Triton C API to capture log messages programmatically.
Motivation
Applications embedding Triton often have their own logging infrastructure and need to integrate Triton's logs rather than having them go to stdout/stderr or a separate file. The current workarounds (parsing log files, named pipes) are clunky and lose metadata like log levels. See triton-inference-server/server#8304.
API
Usage
Setting
replace_default_logger=truesuppresses default stdout/stderr output. Setting it tofalsecalls the callback in addition to normal logging.Dependencies
Requires triton-inference-server/common#149 for the underlying Logger changes.