fix: Fix local source prefix bug #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you @amorari. Could you please raise the PR with a branch under this repository instead of one under your forked repository? This will help the github ci triggered to run the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this error when using --source :
triton - ERROR - Local file path 'local:/workspace/engines/llama-2-7b' provided by --source does not existThis is due to a bug in repository.py where the source is not stripped of the SOURCE_PREFIX_LOCAL before doing Path(source).
Also, the copy assumes a file, but the model is a directory, so adding code to copy the directory and also printing a message while waiting for the copy.