-
Notifications
You must be signed in to change notification settings - Fork 118
Update AutoScaling Blog to 24.07 #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/chart/pvc/storageclass.yaml
Outdated
Show resolved
Hide resolved
@@ -286,11 +283,14 @@ spec: | |||
- name: engine-repository | |||
hostPath: | |||
path: {{ printf "%s/models/%s/%dx%d/engines" $hostRootPath $model_lower (int $model_pp) (int $model_tp) }} | |||
type: DirectoryOrCreate | |||
type: DirectoryOrCreate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra, errant whitespace at end of line.
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/chart/pvc/claim.yaml
Outdated
Show resolved
Hide resolved
apiVersion: v1 | ||
kind: PersistentVolume | ||
metadata: | ||
name: efs-autoscaling-pv-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should pick a more meaningful, and less AWS specific name for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved all pvc charts for aws under pvc_aws folder
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/setup_ssh-efs.yaml
Outdated
Show resolved
Hide resolved
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/containers/server.py
Show resolved
Hide resolved
…rver#108) * Update AutoScaling Blog to 24.08 * Triton CLI removed
Update container file to point to 24.07 instead of 24.04
Update triton cli to point to 24.07 conversion scripts