Skip to content

update and polish llama2 trtllm_guide.md #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

ziqif-nv
Copy link
Contributor

update the guide to make it work and clearer based on my reproducing experience.

NOTE: without the added config in FILL_TEMPLATE_SCRIPT section, the tritionserver deployment would fail due to protobuf parsing errors.

Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the polishing!

Copy link
Contributor

@krishung5 krishung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as well, thanks for the update.

@ziqif-nv ziqif-nv merged commit 8bd14d1 into main Feb 12, 2025
3 checks passed
@ziqif-nv ziqif-nv deleted the ziqif_llama2_trtllm branch February 12, 2025 00:19
fdf3d186-88d5 pushed a commit to fdf3d186-88d5/triton-inference-server that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants