Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the configuration of engineArgs in config.pbtxt #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
change the configuration of engineArgs in config.pbtxt #72
Changes from 4 commits
72efdea
402720b
ad533cd
a583a65
c2f1f3f
9aa49d2
3098bd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you are doing. My only problem is that vLLM repository is under active development and these fields may change in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oandreeva-nv This is a very good question. In fact, just like the sampling parameter processing logic.
We really cannot elegantly handle such parameters that may change in a dynamic way, but generally speaking, the frequency of changes is not large.
We can correct this problem by compile matching versions of
Triton Server + vLLM + model.py
.In fact, 23.10-vllm-python-py3 has been released. The adaptation of
Triton Server + vLLM + model.py
is closed-loop and can run very well. Even you can change themodel.py
in/opt/tritonserver/backends/vllm
of thevllm_backend
container if you need.