Skip to content

[language](fix) Allow non-power-of-two arange ranges #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ritsuka314 wants to merge 1 commit into
base: main-dev
Choose a base branch
from
+1 −6
Open

[language](fix) Allow non-power-of-two arange ranges #1884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions third_party/ascend/patch/triton-ascend-3.6.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,17 +863,12 @@ index 52192cf3e..241ba3378 100644
raise ValueError("wrong type argument to unary invert (" + input_sca_ty.__repr__() + ")")
_1 = self.tensor(self.builder.get_all_ones_value(input_sca_ty.to_ir(self.builder)), input_sca_ty)
return self.xor_(input, _1)
@@ -579,8 +629,11 @@ class TritonSemantic(Generic[TensorTy]):
@@ -579,8 +629,6 @@ class TritonSemantic(Generic[TensorTy]):
if end <= start:
raise ValueError("arange's end argument must be greater than the start argument")
range = end - start
- if (range & (range - 1)) != 0:
- raise ValueError("arange's range must be a power of 2")
+ # Check if compile_mode is simt, then range must be a power of 2
+ if self.builder.is_simt_mode():
+ # Check if range is a power of 2
+ if (range & (range - 1)) != 0:
+ raise ValueError("arange's range must be a power of 2")
shape = [range]
if ret_ty is None:
ret_ty = tl.block_type(tl.int32, shape)
Expand Down
Loading