[libdevice](fix) Remove duplicated deprecated function - #1889
Open
Levein7 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
python
There was a problem hiding this comment.
Pull request overview
This PR removes the locally defined _deprecated decorator from the Ascend CANN libdevice.py and switches the deprecated libdevice wrappers to reuse the shared implementation from cann/extension/_utils.py.
Changes:
- Removed the duplicate
_deprecatedimplementation fromthird_party/ascend/language/cann/libdevice.py. - Added a late import of
_deprecatedfromthird_party/ascend/language/cann/extension/_utils.pyto decorate deprecated libdevice wrapper functions. - Updated deprecated wrapper decorators to pass fully-qualified
fn_nameandreplacementstrings.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Levein7
force-pushed
the
update-libdevice
branch
3 times, most recently
from
September 1, 2026 10:55
aebf871 to
72ed11d
Compare
Levein7
force-pushed
the
update-libdevice
branch
from
September 1, 2026 11:13
72ed11d to
0e243e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding libdevice repo commit:
https://gitcode.com/Ascend/libdevice/commit/3ed2b0b8