[API](feat) Deprecate legacy sync block APIs - #1909
Draft
Misaka19280hw wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The legacy
triton.language.sync_block_all,sync_block_set, andsync_block_waitwrappers still use ad-hocDeprecationWarningcalls. Standardize their sunset behavior with the_deprecatedmechanism introduced formain-dev, and point users to the public Ascend extension APIs.What
_deprecated.triton.language.extra.cann.extension.sync_block_*replacement paths.Validation
pre-commit run --from-ref origin/main-dev --to-ref HEADgit diff origin/main-dev..HEAD --checkpython -m pytest --collect-only -q third_party/ascend/unittest/pytest_ut/test_aux_ops_deprecation.py(3 tests collected)_semanticprotocol; CI builds and installs the current checkout before runningpytest_ut.New contributor declaration
pre-commit run --from-ref origin/main-dev --to-ref HEAD.third_party/ascend/unittest/pytest_ut.littests.