Open
Conversation
peterbell10
force-pushed
the
pb/pr-chain/gsan_model_tmareduceop_as_atomic_eab3
branch
5 times, most recently
from
e402454 to
bf90b0b
Compare
Previously we were modelling it as a non-atomic store. This now models it as atomic, but is still not 100% right as we're doing the shadow cell update eagerly before the TMA operation has completed. git-pr-chain: gsan_model_tmareduceop_as_atomic_eab3
peterbell10
force-pushed
the
pb/pr-chain/gsan_model_tmareduceop_as_atomic_eab3
branch
from
bf90b0b to
e0b528a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[GSan] Model TMAReduceOp as atomic
Previously we were modelling it as a non-atomic store. This now models
it as atomic, but is still not 100% right as we're doing the shadow cell
update eagerly before the TMA operation has completed.
PR chain