Conversation
a36137f to
4e117a3
Compare
|
I would appreciate any suggestions, especially regarding match_any implementations as I don't have access to AMD gpu for testing. |
ThomasRaoux
left a comment
There was a problem hiding this comment.
I think this is out of scope for what we want in Triton unless there are real life use cases for the scatter in ML.
I can immediately think of GNNs, K-nearest neighbors for neural networks working on point clouds, sparse tensor ops. |
|
@denix56 is this something you would consider implementing as an extension? |
yes, sounds like a good idea! |
I have a draft PR that I need to finish up for custom top level DSL ops but it can be done in stages with just adding the ops at the TTGIR level first and invoking with IR over rides. The existing infrastructure should support that today. |
Why
Triton doesn’t currently support scatter, which is needed for index-based writes and parity with common tensor frameworks. This PR adds scatter support with broadcastable indices
and optional reduction semantics (via combine_fn and include_self).
What
Testing
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)