fix(tutorial): correct return order of min/max ms in grouped_gemm benchmark#9432
Merged
Jokeren merged 1 commit intotriton-lang:mainfrom Feb 11, 2026
Merged
Conversation
The grouped_gemm tutorial plots absolute latency `runtime(ms)` on the y-axis, but incorrectly returned `(ms, max_ms, min_ms)` from the benchmark function. This inverted the lower and upper bounds of the error bars in the generated plot. This commit fixes the return order to `(ms, min_ms, max_ms)` to ensure accurate variance visualization.
Jokeren
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)
Description
This PR fixes an issue with inverted error bars in the
grouped_gemmtutorial's performance plot.Currently, the
benchmark_batchesandbenchmark_square_matricesfunction returnsms, max_ms, min_ms. Since the y-axis metric is absoluteruntime(ms), this inadvertently swaps the upper and lower bounds for the error bars in thetriton.testing.perf_reportrendering logic.(Note: Other tutorials correctly use the inverted order because their y-axis is throughput, e.g.,
gbps(min_ms)as the upper bound. This issue is isolated togrouped_gemm.)