[AMD] Disable True16 for assembler on gfx11#9447
Merged
antiagainst merged 1 commit intotriton-lang:mainfrom Feb 13, 2026
Merged
[AMD] Disable True16 for assembler on gfx11#9447antiagainst merged 1 commit intotriton-lang:mainfrom
antiagainst merged 1 commit intotriton-lang:mainfrom
Conversation
We already disable True16 on gfx11 in make_amdgcn, but since a recent LLVM bump the assembler rejects Fake16 instructions by default, requiring us to disable True16 here as well.
antiagainst
approved these changes
Feb 13, 2026
paultrojahnamd
added a commit
to ROCm/triton
that referenced
this pull request
Feb 16, 2026
We already disable True16 on gfx11 in make_amdgcn, but since a recent LLVM bump the assembler rejects Fake16 instructions by default, requiring us to disable True16 here as well. Co-authored-by: Paul Trojahn <paul.trojahn@amd.com>
jataylo
pushed a commit
to jataylo/triton
that referenced
this pull request
Feb 16, 2026
We already disable True16 on gfx11 in make_amdgcn, but since a recent LLVM bump the assembler rejects Fake16 instructions by default, requiring us to disable True16 here as well. Co-authored-by: Paul Trojahn <paul.trojahn@amd.com> (cherry picked from commit ceb2739)
jataylo
pushed a commit
to jataylo/triton
that referenced
this pull request
Feb 16, 2026
We already disable True16 on gfx11 in make_amdgcn, but since a recent LLVM bump the assembler rejects Fake16 instructions by default, requiring us to disable True16 here as well. Co-authored-by: Paul Trojahn <paul.trojahn@amd.com> (cherry picked from commit ceb2739)
atalman
pushed a commit
that referenced
this pull request
Feb 16, 2026
Cherry pick into release branch for Navi stability We already disable True16 on gfx11 in make_amdgcn, but since a recent LLVM bump the assembler rejects Fake16 instructions by default, requiring us to disable True16 here as well. (cherry picked from commit ceb2739) <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [ ] I am not making a trivial change, such as fixing a typo in a comment. - [ ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [ ] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [ ] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) Co-authored-by: Paul Trojahn <paul.trojahn@gmail.com> Co-authored-by: Paul Trojahn <paul.trojahn@amd.com>
ptrojahn
added a commit
to ptrojahn/triton
that referenced
this pull request
Mar 19, 2026
We already disable True16 on gfx11 in make_amdgcn, but since a recent LLVM bump the assembler rejects Fake16 instructions by default, requiring us to disable True16 here as well. Co-authored-by: Paul Trojahn <paul.trojahn@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already disable True16 on gfx11 in make_amdgcn, but since a recent LLVM bump the assembler rejects Fake16 instructions by default, requiring us to disable True16 here as well.