Conversation
lezcano
requested review from
CRobeck,
Jokeren,
antiagainst,
fywkevin,
peterbell10,
ptillet and
zhanglx13
as code owners
Contributor
Author
|
@jeffniu-openai tried it a year after your first try, worked like a charm |
lezcano
commented
Apr 10, 2026
peterbell10
reviewed
Apr 10, 2026
ThomasRaoux
reviewed
Apr 10, 2026
Collaborator
|
Should we enable |
Contributor
Author
I'd be keen to add some more compiler warnings moving forward, but there has been a bit of a pushback historically in doing so. We can discuss this in next week's meeting. For now better to leave this PR as an NFC. |
lezcano
force-pushed
the
static
branch
2 times, most recently
from
aacf3f9 to
091fc27
Compare
peterbell10
requested changes
Apr 14, 2026
Contributor
peterbell10
left a comment
peterbell10
left a comment
There was a problem hiding this comment.
DIdn't bother to go through all of them, but here are the first few
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Contributor
Author
|
Done. The heuristic was "if there is a run of 2 or more ops, do an anon namespace, otherwise use static" for the ops in this PR. There are preexisting cases of runs of plenty of contiguous functions with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Codex noreply@openai.com