fix(core): skip downloading from maven central and ensure relocations #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libby has been forked [1], which adds functionality to avoid downloading the dependencies for relocation from maven central (they are already shaded into the Triton jar), and also includes the hash of the applied relocations to the file names, ensuring they are always up-to-date. Fixes #416 Fixes #417 [1]: https://github.com/tritonmc/libby
diogotcorreia
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libby has been forked 1, which adds functionality to avoid downloading the dependencies for relocation from maven central (they are already shaded into the Triton jar), and also includes the hash of the applied relocations to the file names, ensuring they are always up-to-date.
Fixes #416
Fixes #417