svelte import sort #310
Merged
svelte import sort #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've closed my PR because upon additional inspection I didn't need any of these. What I've needed was an update to recent SvelteKit and proper eslint plugins. |
byara
requested review from
ayusharma and
byara
and removed request for
ayusharma
byara
force-pushed
the
svelte-import-sort
branch
from
66c1567 to
d7bdc8c
Compare
ayusharma
approved these changes
Nov 25, 2024
|
Optional peer dependencies seem to be installed by default in parent projects. This leads to to svelte being installed in all projects, also projects that don't use Svelte at all. That is probably not intentional. See also: #323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw @secondfry did a PR but closed itself.
It is just the same PR with a "postinstall": "patch-package" in the package.json so the prettier-plugin-svelte works