Add support for gjs/gts, fix examples more #376
Conversation
|
@vladislavarsenev @byara this is finally the PR I really needed so we can support Ember's gjs/gts formats. Please let me know what you think of the changes! I also fixed the examples more, as they needed the svelte and ember-template-tag plugins to run. |
|
Thank you for your hard work on this! LTGM |
examples/example.gts
Outdated
| }; | ||
| } | ||
|
|
||
| export default class Foo extends Component<FooSignature> {} No newline at end of file |
There was a problem hiding this comment.
Would it make sense to include a <template> block in these examples?
There was a problem hiding this comment.
Good idea! Hey @RobbieTheWagner could you please some examples with <template> block?
byara
left a comment
byara
left a comment
There was a problem hiding this comment.
Looks good to me. I left a comment only about additional test cases.
Please do not forget to add the support for gjs/gts in the readme file.
Thank you so much for adding this feature 🚀
There was a problem hiding this comment.
Maybe in another test case we can have something with the <template> block here too?
There was a problem hiding this comment.
Turns out things are not working when you have a <template> 😅. I will work on a fix.
|
Closing in favor of #377 |
3 participants
No description provided.