Add proper support for inactive points#107
Merged
efaulhaber merged 17 commits intomainfrom May 13, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 89.27% 89.02% -0.25%
==========================================
Files 13 13
Lines 550 556 +6
==========================================
+ Hits 491 495 +4
- Misses 59 61 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for inactive points in neighborhood searches by introducing a new keyword parameter that restricts the active indices from the provided coordinate arrays. Key changes include:
- Updating test cases to verify behavior with inactive points using a specified index range.
- Modifying various neighborhood search initialization and update functions (in both grid and precomputed implementations) to accept the new eachindex_y parameter.
- Adjusting the core grid search functions to enforce constraints on inactive point handling.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/nhs_grid.jl | Updated tests to pass a specific indices range (eachindex_y) for inactive points. |
| src/nhs_trivial.jl | Added eachindex_y parameter to the trivial search initialization and update functions. |
| src/nhs_precomputed.jl | Introduced eachindex_y in initialization and update functions and propagated it to neighbor list setup. |
| src/nhs_grid.jl | Modified grid initialization and update functions to support selective point processing with eachindex_y. |
| src/neighborhood_search.jl | Extended abstract functions to include eachindex_y for proper inactive point support. |
Comments suppressed due to low confidence (2)
src/nhs_trivial.jl:37
- [nitpick] Consider renaming the parameter 'eachindex_y' to a more descriptive name like 'active_indices' to clarify its role in specifying which points to use.
eachindex_y = axes(y, 2)
src/nhs_grid.jl:215
- [nitpick] Verify that the added bounds check does not introduce significant performance overhead in critical sections; consider conditional enabling for production builds if needed.
@boundscheck checkbounds(y, eachindex_y)
svchb
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.