Add Backend for SpatialHashingCellList#111
Merged
svchb merged 21 commits intotrixi-framework:mainfrom Oct 17, 2025
Merged
Conversation
RubberLanding
force-pushed
the
SpatialHashingBackend
branch
from
558bd39 to
5628e27
Compare
Move check_cell_bounds() and construct_backends() to separate cell_lists_util.jl to share functionality between different cell lists.
RubberLanding
force-pushed
the
SpatialHashingBackend
branch
from
5628e27 to
d5f2960
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 87.84% 86.94% -0.90%
==========================================
Files 15 15
Lines 625 659 +34
==========================================
+ Hits 549 573 +24
- Misses 76 86 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
requested changes
May 26, 2025
efaulhaber
reviewed
May 26, 2025
- Move functions from cell_lists_util.jl to cell_lists.jl - Change dispatch in `supported_update_strategies()` - Change doc string of SHCL (SpatialHashingCellList)
- Add `@inbounds` in `push_cell_atomic!` - Improved type dispatch for `supported_update_strategies` - Clarified and cleaned up cell list initialization and emptying, - General code cleanup.
RubberLanding
force-pushed
the
SpatialHashingBackend
branch
from
62a464a to
24fddaf
Compare
Make cell_list.coords primitive to use Atomix.
…ing/PointNeighbors.jl into SpatialHashingBackend
efaulhaber
requested changes
Sep 14, 2025
Member
efaulhaber
left a comment
efaulhaber
left a comment
There was a problem hiding this comment.
Let's finally finish this old PR.
Please add a test with the new backend to the general NHS tests comparing against trivial.
- Update the tests - Improve the documentation - Minor changes
efaulhaber
approved these changes
Sep 26, 2025
svchb
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option for different backends for SpatialHashingCellList.
Please have a look @efaulhaber .