Convert pos_diff to NHS eltype if coordinates have a different eltype

[efaulhaber]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.96%. Comparing base (5b86d44) to head (f2f33be).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   86.94%   86.96%   +0.01%     
==========================================
  Files          15       15              
  Lines         659      660       +1     
==========================================
+ Hits          573      574       +1     
  Misses         86       86              

Flag	Coverage Δ
unit	86.96% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR adds type conversion for position differences to ensure consistent numerical precision throughout neighborhood search operations, and optimizes the precomputed neighborhood search with @inbounds annotation.

• Adds a new eltype method for AbstractNeighborhoodSearch to retrieve the element type from the search radius
• Converts pos_diff to match the neighborhood search's element type at three key locations
• Adds @inbounds annotation to the extract_svector call in PrecomputedNeighborhoodSearch for a ~20% GPU speedup

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/neighborhood_search.jl	Defines eltype method for AbstractNeighborhoodSearch and applies type conversion to pos_diff in generic foreach_neighbor
src/nhs_grid.jl	Applies type conversion to pos_diff in GridNeighborhoodSearch's specialized foreach_neighbor
src/nhs_precomputed.jl	Applies type conversion to pos_diff and adds @inbounds annotation with updated safety comment in PrecomputedNeighborhoodSearch's foreach_neighbor

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.