Skip to content

Resolve #833 (performance of neural network indicators) #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HenrZu wants to merge 10 commits into from
Closed

Resolve #833 (performance of neural network indicators) #1077

HenrZu wants to merge 10 commits into from
+117 −62

Conversation

@HenrZu
Copy link

@HenrZu HenrZu commented Mar 1, 2022 •
edited by ranocha
Loading

Fixes #833

  • Removed allocations and adding the input size to the cache
  • Evaluation of the network allocates a lot of memory. Currently no known solution to this in Flux. (1)

@HenrZu HenrZu requested a review from sloede March 1, 2022 12:36
@ranocha ranocha added the performance We are greedy label Mar 1, 2022
@ranocha ranocha changed the title Resolve #833 Resolve #833 (performance of neural network indicators) Mar 2, 2022
@DanielDoehring
Copy link
Member

DanielDoehring commented Dec 7, 2025

Close this here as this should probably be migrated to https://github.com/trixi-framework/SmartShockFinder.jl

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Dec 7, 2025

Close this here as this should probably be migrated to trixi-framework/SmartShockFinder.jl

(or https://github.com/trixi-framework/TrixiSmartShockFinder.jl)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloede sloede Awaiting requested review from sloede

Assignees

@sloede sloede

Labels

performance We are greedy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve performance of ANN-based indicators

5 participants

@HenrZu @DanielDoehring @JoshuaLampert @sloede @ranocha