Skip to content

CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ForwardDiff package from 0.10.36 to 0.10.36, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2025-03-27-00-05-21-087-01715210426 branch from 5aea096 to 3f03732 Compare March 27, 2025 00:05
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f41135f) to head (4b22c02).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2320       +/-   ##
==========================================
- Coverage   96.89%   0.00%   -96.89%     
==========================================
  Files         496     496               
  Lines       40759   40493      -266     
==========================================
- Hits        39490       0    -39490     
- Misses       1269   40493    +39224     
Flag Coverage Δ
unittests 0.00% <ø> (-96.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sloede
Copy link
Member

sloede commented Mar 27, 2025

ForwardDiff v1 is not yet used here, which is just as well given that it does not seem to work yet with OrdinaryDiffEq (SciML/OrdinaryDiffEq.jl#2643)

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait until we can test the new version here.

github-actions bot and others added 2 commits March 27, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants