[Proof of Concept] Make ForwardDiff work with implicit time integration #2371
+36
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A beautiful solution for #2369.
I think it's pretty clear that I have absolutely no idea what I'm doing.
I have no idea where the numbers 1 and 11 come from (are these the chunk sizes?), but it works like that for this specific elixir.
We would need to know all dual types that the
rhs!
will be called with, and then we can construct a cache (or in this case a whole semidiscretization) for each of them.No idea how to implement this in a clean way, but at least it demonstrates that this can be done and especially that it can be done in a minimally invasive way without changing all the data structures.