Skip to content

[Proof of Concept] Make ForwardDiff work with implicit time integration #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

efaulhaber
Copy link
Member

A beautiful solution for #2369.

I think it's pretty clear that I have absolutely no idea what I'm doing.
I have no idea where the numbers 1 and 11 come from (are these the chunk sizes?), but it works like that for this specific elixir.

We would need to know all dual types that the rhs! will be called with, and then we can construct a cache (or in this case a whole semidiscretization) for each of them.
No idea how to implement this in a clean way, but at least it demonstrates that this can be done and especially that it can be done in a minimally invasive way without changing all the data structures.

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@efaulhaber
Copy link
Member Author

CC @vchuravy

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.87%. Comparing base (afdb486) to head (0fa2ecb).

Files with missing lines Patch % Lines
...amples/tree_1d_dgsem/elixir_advection_diffusion.jl 0.00% 3 Missing ⚠️
...emidiscretization/semidiscretization_hyperbolic.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
- Coverage   96.93%   96.87%   -0.06%     
==========================================
  Files         501      501              
  Lines       41589    41596       +7     
==========================================
- Hits        40314    40295      -19     
- Misses       1275     1301      +26     
Flag Coverage Δ
unittests 96.87% <28.57%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant