Skip to content

Add AMDGPU CI and support AMDGPU through KernelAbstractions#2834

Merged
ranocha merged 14 commits intomainfrom
vc/amdgpu
Mar 31, 2026
Merged

Add AMDGPU CI and support AMDGPU through KernelAbstractions#2834
ranocha merged 14 commits intomainfrom
vc/amdgpu

Conversation

@vchuravy
Copy link
Copy Markdown
Member

@vchuravy vchuravy commented Feb 26, 2026

  • Add CI for AMDGPU.jl
  • add extension for AMDGPU
  • fixup! add extension for AMDGPU

Partially co-written by Claude Code.

Sibling to #2833 and child PR to #2590

TODO

@github-actions
Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@vchuravy vchuravy mentioned this pull request Mar 4, 2026
3 tasks
@vchuravy vchuravy changed the base branch from vc/metal to feature-gpu-offloading March 16, 2026 16:08
@vchuravy vchuravy marked this pull request as ready for review March 16, 2026 16:08
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.07%. Comparing base (4c42b01) to head (67d27de).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ext/TrixiAMDGPUExt.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
- Coverage   97.09%   97.07%   -0.02%     
==========================================
  Files         609      610       +1     
  Lines       47493    47501       +8     
==========================================
  Hits        46111    46111              
- Misses       1382     1390       +8     
Flag Coverage Δ
unittests 97.07% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from feature-gpu-offloading to main March 26, 2026 16:48
@vchuravy vchuravy requested review from benegee and sloede March 26, 2026 16:59
benegee
benegee previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Contributor

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ranocha
Copy link
Copy Markdown
Member

ranocha commented Mar 27, 2026

Could you please adapt the compat bounds to fix Downgrade CI?

sloede
sloede previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! I'd also like to have @ranocha take a quick look before merging this

@vchuravy vchuravy requested a review from ranocha March 27, 2026 21:07
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have a minor comment.

ranocha
ranocha previously approved these changes Mar 30, 2026
@ranocha
Copy link
Copy Markdown
Member

ranocha commented Mar 30, 2026

Can you please fix the buildkite CI job?

Copy link
Copy Markdown
Contributor

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try again, with #2904 merged.

Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha ranocha enabled auto-merge (squash) March 31, 2026 07:53
@ranocha ranocha disabled auto-merge March 31, 2026 11:25
@ranocha ranocha merged commit e56e2fd into main Mar 31, 2026
38 of 39 checks passed
@ranocha ranocha deleted the vc/amdgpu branch March 31, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants