WIP: add fused interface 3D GPU kernels#3077
Draft
MarcoArtiano wants to merge 1 commit into
Draft
Conversation
Contributor
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main
this branch
As we can see from the summary callback, the reset function takes an unreasonably amount of time, and probably we should try to fuse jacobian and calc source terms. These are very easy to fuse, as they share the same structure. Instead fusing surface integral with the aforementioned kernels might be a little bit trickier and therefore might not be worth the effort.
We should probably go back to the volume kernel and introduce same type of local share memory (kind of following the same spirit as the turbo version on CPU) and providing also a structure for a turbo version where the primitive variables are precomputed. These steps follows also the optimizations done in the recent paper from Waterhouse and coauthors, about Entropy Stable Euler on GPU.
This PR was created with assistance from Claude.