Skip to content

Method for1d block fv#3095

Draft
MagalieHeinrich wants to merge 20 commits into
trixi-framework:mainfrom
MagalieHeinrich:MethodFor1dBlockFV
Draft

Method for1d block fv#3095
MagalieHeinrich wants to merge 20 commits into
trixi-framework:mainfrom
MagalieHeinrich:MethodFor1dBlockFV

Conversation

@MagalieHeinrich

Copy link
Copy Markdown
Contributor

Added method for plotting via Plots.jl/Makie.jl for TreeMesh1D if the solver is BlockFV.
This is described in issue #30687 (Block finite volume methods).

I tested the methof with

trixi_include("../examples/tree_1d_blockfv/elixir_advection_basic.jl", n_nodes = 4, initial_refinement_level = 3); plot(sol)

which resulted in this graph

bockfv

I also ran

trixi_include("../examples/tree_1d_dgsem/elixir_advection_finite_volume.jl", polydeg = 0, initial_refinement_level = 5); plot(sol)

which resulted in this graph

dgsem

The idea behind comparing these is to verify the block finite volume method against the standard finite volume method at an identical global resolution.

Case DGSEM: An initial refinement level of 5 yields 2^5=32 cells.
Case BlockFV: The total resolution of a level 3 mesh (2^3=8 blocks) where each block is subdivided into 4 subcells is also 32 (8*4=32).

@github-actions

Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.86%. Comparing base (28bf3a9) to head (9957bc7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/visualization/types.jl 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
- Coverage   96.88%   96.86%   -0.02%     
==========================================
  Files         647      647              
  Lines       50026    50068      +42     
==========================================
+ Hits        48466    48495      +29     
- Misses       1560     1573      +13     
Flag Coverage Δ
unittests 96.86% <97.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ranocha

ranocha commented Jun 23, 2026

Copy link
Copy Markdown
Member

When you update the tests as discussed offline, can you please also add a test whethere the DGSEM with polydeg = 0 and the equivalent BlockFV discretizations result in (approximately) the same plot data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants