Method for1d block fv#3095
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3095 +/- ##
==========================================
- Coverage 96.88% 96.86% -0.02%
==========================================
Files 647 647
Lines 50026 50068 +42
==========================================
+ Hits 48466 48495 +29
- Misses 1560 1573 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ch/Trixi.jl into MethodFor1dBlockFV
|
When you update the tests as discussed offline, can you please also add a test whethere the |
Added method for plotting via Plots.jl/Makie.jl for TreeMesh1D if the solver is BlockFV.
This is described in issue #30687 (Block finite volume methods).
I tested the methof with
trixi_include("../examples/tree_1d_blockfv/elixir_advection_basic.jl", n_nodes = 4, initial_refinement_level = 3); plot(sol)
which resulted in this graph
I also ran
trixi_include("../examples/tree_1d_dgsem/elixir_advection_finite_volume.jl", polydeg = 0, initial_refinement_level = 5); plot(sol)
which resulted in this graph
The idea behind comparing these is to verify the block finite volume method against the standard finite volume method at an identical global resolution.
Case DGSEM: An initial refinement level of 5 yields 2^5=32 cells.
Case BlockFV: The total resolution of a level 3 mesh (2^3=8 blocks) where each block is subdivided into 4 subcells is also 32 (8*4=32).