Add solution_container and auxiliary_container for covariant DGMulti solver to match upstream refactor#163
Merged
tristanmontoya merged 17 commits intomainfrom Mar 19, 2026
Conversation
…m/fix_dgmulti_threading
…m/fix_dgmulti_threading
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 97.08% 97.09%
=======================================
Files 37 37
Lines 5010 5019 +9
=======================================
+ Hits 4864 4873 +9
Misses 146 146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benegee
approved these changes
Mar 19, 2026
Collaborator
benegee
left a comment
There was a problem hiding this comment.
Thanks for the effort!
I checked this locally with the current main branch of Trixi and it worked!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have kept the contents of
solution_containerin the top-level cache as well for compatibility with the released version of Trixi.jl in the meantime. This should not actually duplicate any data. This change should hopefully allow both TrixiAtmo.jl CI and Trixi.jl's downstream tests to pass, addressing #159 for real this time.