Skip to content

Add solution_container and auxiliary_container for covariant DGMulti solver to match upstream refactor#163

Merged
tristanmontoya merged 17 commits intomainfrom
tm/match_upstream_dgmulti_refactor
Mar 19, 2026
Merged

Add solution_container and auxiliary_container for covariant DGMulti solver to match upstream refactor#163
tristanmontoya merged 17 commits intomainfrom
tm/match_upstream_dgmulti_refactor

Conversation

@tristanmontoya
Copy link
Copy Markdown
Member

@tristanmontoya tristanmontoya commented Mar 19, 2026

I have kept the contents of solution_container in the top-level cache as well for compatibility with the released version of Trixi.jl in the meantime. This should not actually duplicate any data. This change should hopefully allow both TrixiAtmo.jl CI and Trixi.jl's downstream tests to pass, addressing #159 for real this time.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (338e6bc) to head (d6ddfc8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   97.08%   97.09%           
=======================================
  Files          37       37           
  Lines        5010     5019    +9     
=======================================
+ Hits         4864     4873    +9     
  Misses        146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort!

I checked this locally with the current main branch of Trixi and it worked!

@tristanmontoya tristanmontoya merged commit f60d356 into main Mar 19, 2026
10 checks passed
@tristanmontoya tristanmontoya deleted the tm/match_upstream_dgmulti_refactor branch March 19, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants