Conversation
|
@MarcoArtiano Maaybe some things still need to be adapted to your equations. |
Thanks! I think the source term might need an adjustment. I'll take a look at that. |
MarcoArtiano
left a comment
There was a problem hiding this comment.
Thanks Benedict! I've added a few comments/suggestions.
Co-authored-by: Marco Artiano <57838732+MarcoArtiano@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 30 30
Lines 3903 3903
=======================================
Hits 3798 3798
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I addressed the remaining points, @MarcoArtiano. I particular, I corrected the source terms as discussed. TrixiAtmo.jl/test/test_3d_potential_temperature.jl Lines 177 to 182 in 0d3429a to select a higher tolerance, but only when running on macOS. Something like this could be helpful in other PRs as well, I think. |
MarcoArtiano
left a comment
There was a problem hiding this comment.
Thanks Benedict! I just left a minor comment.
* add Held-Suarez test case * Apply suggestions from code review Co-authored-by: Marco Artiano <57838732+MarcoArtiano@users.noreply.github.com> * correct source terms * fix typo * updated reference values * move and add CI_ON_WINDOWS/MACOS * increase error tolerance for macos in CI * fmt * increase tolerance * and again * rename temperature to T --------- Co-authored-by: Marco Artiano <57838732+MarcoArtiano@users.noreply.github.com>
Implemented following Souza et al..