Skip to content

Add Held-Suarez test case#122

Merged
benegee merged 13 commits intomainfrom
bg/held-suarez
Dec 16, 2025
Merged

Add Held-Suarez test case#122
benegee merged 13 commits intomainfrom
bg/held-suarez

Conversation

@benegee
Copy link
Copy Markdown
Collaborator

@benegee benegee commented Oct 23, 2025

Implemented following Souza et al..

@benegee
Copy link
Copy Markdown
Collaborator Author

benegee commented Oct 23, 2025

@MarcoArtiano Maaybe some things still need to be adapted to your equations.

@MarcoArtiano
Copy link
Copy Markdown
Collaborator

@MarcoArtiano Maaybe some things still need to be adapted to your equations.

Thanks! I think the source term might need an adjustment. I'll take a look at that.

Copy link
Copy Markdown
Collaborator

@MarcoArtiano MarcoArtiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Benedict! I've added a few comments/suggestions.

Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl Outdated
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl Outdated
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl Outdated
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl Outdated
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl Outdated
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl Outdated
Comment thread test/test_3d_potential_temperature.jl
Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl
benegee and others added 2 commits October 28, 2025 17:11
Co-authored-by: Marco Artiano <57838732+MarcoArtiano@users.noreply.github.com>
@benegee benegee marked this pull request as ready for review October 28, 2025 16:17
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (4119575) to head (3bf0b0a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          30       30           
  Lines        3903     3903           
=======================================
  Hits         3798     3798           
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benegee
Copy link
Copy Markdown
Collaborator Author

benegee commented Dec 15, 2025

I addressed the remaining points, @MarcoArtiano.

I particular, I corrected the source terms as discussed.
I also added

import ..CI_ON_MACOS
if CI_ON_MACOS
global _rtol = 7e-8 # increased error tolerance
else
global _rtol = sqrt(eps(Float64)) # default
end

to select a higher tolerance, but only when running on macOS. Something like this could be helpful in other PRs as well, I think.

@benegee benegee requested a review from MarcoArtiano December 15, 2025 15:49
Copy link
Copy Markdown
Collaborator

@MarcoArtiano MarcoArtiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Benedict! I just left a minor comment.

Comment thread examples/elixir_euler_potential_temperature_held_suarez.jl Outdated
@benegee benegee merged commit 7de9867 into main Dec 16, 2025
10 checks passed
@benegee benegee deleted the bg/held-suarez branch December 16, 2025 08:18
PhilBaa pushed a commit to PhilBaa/TrixiAtmo.jl that referenced this pull request Jan 26, 2026
* add Held-Suarez test case

* Apply suggestions from code review

Co-authored-by: Marco Artiano <57838732+MarcoArtiano@users.noreply.github.com>

* correct source terms

* fix typo

* updated reference values

* move and add CI_ON_WINDOWS/MACOS

* increase error tolerance for macos in CI

* fmt

* increase tolerance

* and again

* rename temperature to T

---------

Co-authored-by: Marco Artiano <57838732+MarcoArtiano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants